Aaron Lehmann comments

Results 113 comments of


                                            Aaron Lehmann

Refactor NewImageSource to add a manifest type abstraction

@mtrmac: PTAL - thanks!

Refactor NewImageSource to add a manifest type abstraction

@rhatdan @mtrmac: Would it be possible to get some eyes on this when you have a moment? I was asked to do this to unblock #5452, so I would really...

Refactor NewImageSource to add a manifest type abstraction

Any possibility of moving this forward? It's a bit frustrating that I was asked to come back and do this refactor, but the PR is not getting reviewed.

Refactor NewImageSource to add a manifest type abstraction

@TomSweeneyRedHat @mtrmac @Honny1: Would any of you be able to look at this? I've been trying to get this through for a very long time.

Refactor NewImageSource to add a manifest type abstraction

Rebased.

Refactor NewImageSource to add a manifest type abstraction

Hi @flouthoc, have you had a chance to look at this yet?

Refactor NewImageSource to add a manifest type abstraction

Rebased again.

Refactor NewImageSource to add a manifest type abstraction

@flouthoc: Hoping I can get this merged before it needs yet another rebase :smile:

Refactor NewImageSource to add a manifest type abstraction

@nalind: Thanks for the review - updated based on your feedback.

Refactor NewImageSource to add a manifest type abstraction

@nalind @flouthoc: Any further comments?