jekyll-webmention_io icon indicating copy to clipboard operation
jekyll-webmention_io copied to clipboard

Published 20 hours ago • verified publisher icon aarongustafson

Fix problem with ordered list markup creating invalid HTML

Open dltj opened this issue 4 years ago • 2 comments

Fixes https://github.com/aarongustafson/jekyll-webmention_io/issues/148

dltj avatar Jul 11 '21 00:07 dltj

I kept having Ruby/Jekyll issues when upgrading my Mac, so I have moved off of Jekyll and will not be working on this project anymore, going forward. I am going to flag this as won’t fix, but leave it open in case someone else wants to pick up the project from here.

aarongustafson avatar Jul 22 '21 21:07 aarongustafson

Honestly, I have a much bigger concern that we're getting untrusted, third party content in the form of webmentions, and we're passing it through a markdown parser. I need to look at the history and code flow, here, as, naively, that seems strange to me...

fancypantalons avatar Nov 13 '21 23:11 fancypantalons

I'm gonna close this PR as I believe the actual, proper fix, here, is to stop running webmention content through a markdown parser in the first place, as at least with webmention.io, we're gonna receive text or sanitized HTML, not markdown.

fancypantalons avatar Feb 25 '23 16:02 fancypantalons

Sounds good. The Markdown parsing predated HTML in the feed.

aarongustafson avatar Feb 25 '23 18:02 aarongustafson

I'm gonna close this PR as I believe the actual, proper fix, here, is to stop running webmention content through a markdown parser in the first place, as at least with webmention.io, we're gonna receive text or sanitized HTML, not markdown.

Makes sense—thanks for your efforts, @fancypantalons.

dltj avatar Feb 25 '23 22:02 dltj