vision-camera-ocr icon indicating copy to clipboard operation
vision-camera-ocr copied to clipboard

Published 20 hours ago • verified publisher icon aarongrider

Ambiguity in BoundingFrame Type

Open hawekotte opened this issue 2 years ago • 1 comments

Hey, hey! Love the plugin! 🙏

It looks like right now that for the type definition of BoundingFrame (code link) we have the x and y elements alluded to as the top and left coordinates, respectively. This is mainly due to the fact that we also have boundingCenterX and boundingCenterY included in the object.

But according to getFrame in Android (code link) we are setting x and y to be the exactCenter coordinates.

This appears to almost be a copy of what we are storing for boundingCenter*, and since the Rect object in Kotlin offer left and top properties (doc link) would it make more sense to swap to using those for x and y, respectively?

Edit: It's also worth noting that on iOS we appear to handle the calculation of x and y manually, thus converting them to be top and left, respectively (code link).

hawekotte avatar Apr 01 '22 22:04 hawekotte