BetterDiscordStuff icon indicating copy to clipboard operation
BetterDiscordStuff copied to clipboard

[ChannelTabs] Issue: Unnecessary grey area when fullscreenned

Open Break-Ben opened this issue 2 years ago • 6 comments

Describe the bug On the macOS version of discord, this plugin adds a relatively large grey area at the top of the screen, likely to make room for the 3 dot buttons (fullscreen/minimise/close). This makes sense when discord is not fullscreenned, but when it is fullscreenned, the dots are hidden, meaning the extra space does not need to be there and only takes up space.

To Reproduce Steps to reproduce the behavior:

  1. Install ChannelTabs on macOS
  2. Fullscreen discord

Expected behavior There should be no unnecessary grey area in fullscreen mode.

Screenshots Example of issue

Information (please complete the following information):

  • OS: MacOS
  • Plugin Version: 2.6.1
  • Discord version: Stable
  • Compact Mode enabled: either (enabled in screenshot)

Break-Ben avatar May 07 '22 05:05 Break-Ben

Does it happen without the plug-in

maenDisease avatar May 07 '22 07:05 maenDisease

Does it happen without the plug-in

No, it is only there when the plugin is enabled I know I said this already but was likely added to the plugin on purpose to fix overlap issues with the 3 dot buttons (that you can't see when fullscreenned)

Break-Ben avatar May 07 '22 07:05 Break-Ben

Does it happen without the theme, and what theme is it so I can test tomorrow?

maenDisease avatar May 07 '22 07:05 maenDisease

It does still show with no theme (and a reload), although the grey area does now blend with the rest of the tab area (as shown in the image below) Screen Shot 2022-05-07 at 3 32 04 pm I'm assuming you don't need to know the theme then but in case you do, it is Material_Discord with Material_You

Break-Ben avatar May 07 '22 07:05 Break-Ben

You can use this as a temporary solution. This goes in your Custom CSS.

html.platform-osx .typeMacOS-3V4xXE {
	position: absolute;
	width: unset;
}

.channelTabs-tabContainer::before {
	content:'';
	height: 100%;
	width: 72px;
}

.channelTabs-tabContainer {
	-webkit-app-region: drag;
}

.channelTabs-tabContainer>* {
	-webkit-app-region: no-drag;
}

html .channelTabs-newTab {
	margin-right: calc(6px + 72px);
}```

maenDisease avatar May 07 '22 19:05 maenDisease

You can use this as a temporary solution. This goes in your Custom CSS.

It works great, thanks! Also, in case anyone sees this that also only uses discord on mac in fullscreen mode, you can delete/comment out this part of that CSS that makes space for the 3 dots for it to be a bit cleaner

.channelTabs-tabContainer::before {
	content:'';
	height: 100%;
	width: 72px;
}

Break-Ben avatar May 08 '22 05:05 Break-Ben