Aaron Beitch comments

Results 15 comments of


                                            Aaron Beitch

protoc-gen-go-grpc gRPC code generation plugin downgraded

Fixed by #190

protoc-gen-go-grpc gRPC code generation plugin downgraded

@marcushines #190 looks to have missed regeneration of packet_link_qualification and packet_capture. They are both missing _grpc.pb.go files.

Dependency on "testing" from "google.golang.org/grpc/experimental/stats"

To add a bit more color here, in our repo we check for unexpected dependencies of our binaries. This is done to reduce binary bloat, to avoid side effects of...

Dependency on "testing" from "google.golang.org/grpc/experimental/stats"

We have a small program (that's not open source, sorry) that uses [golang.org/x/tools/go/packages](https://pkg.go.dev/golang.org/x/tools/go/packages) to load a package and walk its dependency tree, reporting any uses of forbidden dependencies. Another simple...

HBASE-28569: fix race condition during WAL splitting leading to corru…

LGTM. @Apache9 Would you mind taking another look?