treesheets icon indicating copy to clipboard operation
treesheets copied to clipboard

flatpak package error

Open qua-rus opened this issue 9 months ago • 10 comments

The flatpak package has been updated again, but now it gives the error:

Image

qua-rus avatar Mar 22 '25 04:03 qua-rus

Can repro since the first flatpak update today (13987213009).

$ flatpak run com.strlen.TreeSheets
/run/build/TreeSheets/lib/wxWidgets/src/unix/fswatcher_inotify.cpp(66): assert "loop" failed in Init(): File system watcher needs an event loop
/run/build/TreeSheets/lib/wxWidgets/src/unix/fswatcher_inotify.cpp(100): assert "IsOk()" failed in DoAdd(): Inotify not initialized or invalid inotify descriptor

The last flatpak update ~3mths ago was 12421969184

Looking at the commits between https://github.com/aardappel/treesheets/compare/12421969184...13987213009 one seems possibly related: Construct wxFileSystemWatcher on startup https://github.com/aardappel/treesheets/commit/0575002d8e66d047b68395a04bceb1e3365ad12a


Btw, it's better to copy-and-paste any error messages instead of posting screenshots, so they can be searched.

jn64 avatar Mar 22 '25 17:03 jn64

Does the same issue occur when the Ubuntu build (see Release section) is used on Ubuntu LTS?

tobiolo avatar Mar 22 '25 18:03 tobiolo

Just updated flatpak package (14007388016), error is still there:

~$ flatpak run com.strlen.TreeSheets
Gtk-Message: 15:35:21.110: Failed to load module "xapp-gtk3-module"
/run/build/TreeSheets/lib/wxWidgets/src/unix/fswatcher_inotify.cpp(66): assert "loop" failed in Init(): File system watcher needs an event loop
15:35:23: Debug: "Left" must use modifiers to be used as a keyboard accelerator with GTK
15:35:23: Debug: "Right" must use modifiers to be used as a keyboard accelerator with GTK
15:35:23: Debug: "Left" must use modifiers to be used as a keyboard accelerator with GTK
15:35:23: Debug: "Right" must use modifiers to be used as a keyboard accelerator with GTK
15:35:23: Debug: "Ctrl+Shift+Tab" is not supported as a keyboard accelerator with GTK
/run/build/TreeSheets/lib/wxWidgets/src/unix/fswatcher_inotify.cpp(100): assert "IsOk()" failed in DoAdd(): Inotify not initialized or invalid inotify descriptor

Maybe this is related to #688 ?

qua-rus avatar Mar 23 '25 12:03 qua-rus

Does the same issue occur when the Ubuntu build (see Release section) is used on Ubuntu LTS?

Since #832 fixed, .deb works on Ubuntu 24.04, so this issue seems unique to flatpak.

jn64 avatar Mar 24 '25 04:03 jn64

I confirm that I have the same problem with installing Flatpak under Fedora

bepolymathe avatar Apr 11 '25 13:04 bepolymathe

Hi, I'm one of the co-maintainers of treesheets-git on AUR https://aur.archlinux.org/packages/treesheets-git

an user reported this same error and I'm confirming it too by building from the latest commit

FabioLolix avatar Apr 21 '25 13:04 FabioLolix

Weird, so the issue is present in flatpak and AUR, but not deb.

flatpak is built with -DGIT_WXWIDGETS_SUBMODULES=OFF -DTREESHEETS_WITH_STATIC_WXWIDGETS=ON. wxWidgets submodule in this repo currently points to a2d33fc (~10 mths old)

.deb is built with -DGIT_WXWIDGETS_SUBMODULES=ON At the time of the latest TS release last week (build log), latest wxWidgets was 26b4292.

AUR treesheets-git is built with -DGIT_WXWIDGETS_SUBMODULES=OFF -DTREESHEETS_WITH_STATIC_WXWIDGETS=OFF, using Arch's wxwidgets-gtk 3.2.7.1 (?)


I built a .deb with -DGIT_WXWIDGETS_SUBMODULES=OFF -DTREESHEETS_WITH_STATIC_WXWIDGETS=ON. wxWidgets is a2d33fc, same as the flatpak, but this .deb doesn't have this issue. Tested in Ubuntu 24.04 VM.

jn64 avatar Apr 21 '25 17:04 jn64

using Arch's wxwidgets-gtk 3.2.7.1 (?)

Yes

-DGIT_WXWIDGETS_SUBMODULES=OFF -DTREESHEETS_WITH_STATIC_WXWIDGETS=ON.

I can't build with that, I got:

-- Detecting CXX compile features - done
CMake Error at CMakeLists.txt:109 (add_subdirectory):
  The source directory

    /home/fabio/Dev/AURNEW3/treesheets-git/src/treesheets/lib/wxWidgets

  does not contain a CMakeLists.txt file.


-- Configuring incomplete, errors occurred!

FabioLolix avatar Apr 21 '25 18:04 FabioLolix

For -DGIT_WXWIDGETS_SUBMODULES=OFF -DTREESHEETS_WITH_STATIC_WXWIDGETS=ON:

Your lib/wxWidgets submodule is not initialised.

E.g. in already cloned treesheets dir:

git submodule update --init --recursive

or cloning from the start with submodules

git clone --recurse-submodules https://github.com/aardappel/treesheets

Must be recursive because wxWidgets itself contains submodules.

Not sure about the correct way for PKGBUILD / Arch policy.


Alternatively -DGIT_WXWIDGETS_SUBMODULES=ON updates the submodules for you (you don't need to do any of the above)

jn64 avatar Apr 21 '25 18:04 jn64

Your lib/wxWidgets submodule is not initialised.

Ah ok

Must be recursive because wxWidgets itself contains submodules. Not sure about the correct way for PKGBUILD / Arch policy.

Coincidentally I'm also maintaining the git version of wxWidgets https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=wxgtk-git

I've made a variant pkgbuild which use the submodules instead of the system version but there is the same problem https://github.com/FabioLolix/PKGBUILD-WIP/commit/e24fb20e3a719c9ac8fcdf26da414c109fb10bef

FabioLolix avatar Apr 21 '25 21:04 FabioLolix

Seems fixed by 3a0dcf1, tag 15520961560

The update has been published on Flathub.

At least, there's no more error on startup, but I didn't test any functionality.

jn64 avatar Jun 09 '25 11:06 jn64

Also on Arch it works again

FabioLolix avatar Jun 15 '25 16:06 FabioLolix