Crashes in `FindNextSearchMatch` when called from `OnTabChange`

[aardappel]

I've seen this crash log a few times now:

C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.37.32822\include\xstring (2492): std::basic_string<wchar_t,std::char_traits<wchar_t>,std::allocator<wchar_t> >::basic_string<wchar_t,std::char_traits<wchar_t>,std::allocator<wchar_t> >
C:\w\treesheets\src\cell.h (416): treesheets::Cell::FindNextSearchMatch
C:\w\treesheets\src\document.h (2020): treesheets::Document::SearchNext
C:\w\treesheets\src\myframe.h (826): treesheets::MyFrame::OnTabChange

It's an illegal access: ExpCode: 0xC0000005 ExpFlags: 0 ExpAddress: 0x69D4405B

I can't see from the code why it would do this, but it looks like some part of the state is not set up correctly when switching tabs.

[tobiolo]

@aardappel How do you reproduce the crash?

[aardappel]

Not sure.. it happened at random times when I was using the app as a user in release mode, so only have that log to go on.

My guess is to have something active in the search bar, then switch tabs in some combination..

[tobiolo]

I tried to reproduce the issue on Linux (wxGTK) but it does not seem to be a problem there. I will try it out the next time I cross a Windows installation.

[aardappel]

Yeah I can repro it either, but wanted us to be aware since it has happened multiple times.. I'll be on the lookout as well.