treesheets icon indicating copy to clipboard operation
treesheets copied to clipboard

[Feature Request] Load Images From File Path

Open AntonBogun opened this issue 1 year ago • 7 comments

It would be nice if treesheets could display images using file paths rather than having to copy the image into the treesheet. The issue with the latter is that if many images are present in the treesheet, its size becomes large and saving starts to take a long time. If treesheets loaded the image on demand from image files then this problem would go away.

AntonBogun avatar Feb 14 '23 18:02 AntonBogun

Agree that would be a nice feature.. an image could be either internal or external, with ways to switch between them.

aardappel avatar Feb 14 '23 18:02 aardappel

Would it be possible to do this by just replacing the image loading logic to instead perform a file read?

AntonBogun avatar Feb 14 '23 22:02 AntonBogun

We'd certainly want to keep the current feature of having internal images as default, as for many use cases it is better. Implementing that properly would be a bit more work than what you seem to be suggesting.

aardappel avatar Feb 14 '23 22:02 aardappel

Not planned? Really? Is this feature really not that useful? I have to hard disagree on this.

AntonBogun avatar Nov 30 '23 10:11 AntonBogun

I guess github doesn't give a lot of nuance between "we don't have plans for someone to implement this right now" vs "not planned until someone wants to actually implement it" vs "not planned because we never want it".

I'd say this could be a useful feature, if carefully implemented with good UI & code, but it seems neither myself or @t2b3 has plans to implement it any time soon.. so it really is in the second of those :)

@t2b3, maybe issues that are "this would be a good feature to have, but maintainers don't plan to work on it" could be left open, and instead mark them with "PR welcome" or similar?

Also note @AntonBogun that closing an issue is not the end of the world.. its easy to reopen the moment someone says they'll work on it

aardappel avatar Nov 30 '23 17:11 aardappel

I just added a PR welcome label, that is for "this would be a good feature to have, but maintainers don't plan to work on it"

aardappel avatar Nov 30 '23 17:11 aardappel

I guess github doesn't give a lot of nuance between "we don't have plans for someone to implement this right now" vs "not planned until someone wants to actually implement it" vs "not planned because we never want it".

I'd say this could be a useful feature, if carefully implemented with good UI & code, but it seems neither myself or @t2b3 has plans to implement it any time soon.. so it really is in the second of those :)

@t2b3, maybe issues that are "this would be a good feature to have, but maintainers don't plan to work on it" could be left open, and instead mark them with "PR welcome" or similar?

Also note @AntonBogun that closing an issue is not the end of the world.. its easy to reopen the moment someone says they'll work on it

@aardappel thanks for your reply! I applied the proposed scheme to some other issues as well.

tobiolo avatar Nov 30 '23 21:11 tobiolo