procrastitracker icon indicating copy to clipboard operation
procrastitracker copied to clipboard

[PENDING] Support languages other than English

Open sergeevabc opened this issue 5 years ago • 11 comments

Dear @aardappel, your application belongs to the works of the 21st century, yet it seems not to be aware of Unicode:

  • HTML export is done without UTF8, so we see Не в себе instead of Не в себе
  • filter on sub-string within Statistics View does not work with Russian input (e.g. себе)

Would you mind fixing it?

sergeevabc avatar Jan 18 '19 12:01 sergeevabc

It does collect data correctly in UTF-8 (for the window title and exe name, not sure about browser url), so the problem is hopefully just in these two places. Let me have a look.

aardappel avatar Jan 18 '19 21:01 aardappel

Hmm, for me in Chrome it seems to work, I see in the html output e.g.

30 blah.ru - 0% of parent, 8 keys, 3 lmb25BLAH! Чепуха - истории, новости и много интересного - Google Chrome - 83% of parent, 2 lmb, 13:25 start on 2019-1-18 25 BLAH! Чепуха - истории, новости и много интересного - Google Chrome - 83% of parent, 2 lmb, 13:25 start on 2019-1-18
25 BLAH! Чепуха - истории, новости и много интересного - Google Chrome - 83% of parent, 2 lmb, 13:25 start on 2019-1-18

aardappel avatar Jan 18 '19 21:01 aardappel

Fixed filter widget: https://github.com/aardappel/procrastitracker/commit/09dd43db8ddb83e4d5e0cbf8d1bf832c13819d0e

aardappel avatar Jan 18 '19 21:01 aardappel

Chrome treats HTML without specified encoding as UTF8. Its market share is ~65%, but what about the rest? Other browsers need a nudge by means of <meta charset="utf-8"> within <head>…</head>.

sergeevabc avatar Jan 18 '19 21:01 sergeevabc

Also now declare UTF-8 in html export, maybe that will fix it: https://github.com/aardappel/procrastitracker/commit/efee06ffb2b0a664b5cb788b9eb9cb9286d5ef93

aardappel avatar Jan 18 '19 21:01 aardappel

And just updated installer on the site again, including these 2 fixes. Let me know if it works for you.

aardappel avatar Jan 18 '19 21:01 aardappel

Export works as expected now. Filter on sub-string (by the way, it sounds sophisticated to me) works as well, but… case-sensitive for Russian all of a sudden. Is this intentional?

sergeevabc avatar Jan 18 '19 22:01 sergeevabc

No, it works case insensitive with english text, but again this uses non-unicode aware code. Had a look at what it takes to fix this, and this one is a bit more involved to fix, so may have to wait.

aardappel avatar Jan 18 '19 23:01 aardappel

Is there anything a mere Windows user like me could do to expedite a resolution of this issue?

sergeevabc avatar Apr 14 '19 06:04 sergeevabc

This is one of many open source projects I support, and doesn't make me any money. So whether a feature gets implemented depends on whether I or some other programmer want to. If you know someone who could help, that could expedite it.

aardappel avatar Apr 14 '19 15:04 aardappel

Err… Hello?

sergeevabc avatar Jul 03 '20 04:07 sergeevabc