smhasher icon indicating copy to clipboard operation
smhasher copied to clipboard

Should MurmurHash3_x64_128 take a uint64_t seed parameter instead?

Open scritturamista opened this issue 8 years ago • 1 comments

The 32-bit seed parameter is used to initialize the two 64-bit h1 and h2 variables. Would it make sense (and would it make any qualitative difference) to allow a 64-bit seed value instead?

void MurmurHash3_x64_128 ( const void * key, const int len, const uint32_t seed, void * out )

[...]

uint64_t h1 = seed; uint64_t h2 = seed;

[...]

Thank you!

scritturamista avatar Dec 21 '17 20:12 scritturamista

Would it make sense (and would it make any qualitative difference) to allow a 64-bit seed value instead?

Shortly - no. For longer answer see https://github.com/aappleby/smhasher/issues/56#issuecomment-380782966.

sebres avatar Apr 12 '18 12:04 sebres