Amir Omidi

Results 130 comments of Amir Omidi

I wonder if this solves this bug: https://github.com/testcontainers/testcontainers-go/issues/2749 I'll do a small code review here as well. Thank you for this!

I've personally found that trying to use bazel with any IDE outside of Google has been a _really not great_ experience. Am I holding it wrong?

The reason I'm thinking of introducing this lint isn't really to penalize CAs or whatever. It's definitely nothing more than a warning. I'm also planning on making it warn on...

> My personal opinion is that the entropy requirements on serial numbers are a defense against bad hash functions, and we've more directly solved that already by removing SHA-1 and...

> it should probably be an INFO- or NOTICE-level lint. I am in agreement here.

> One more thing we see repeatedly in some WebPKI incidents is CAs not understanding the requirements, and assuming the linters will tell them if they're doing something wrong. This...

> But we should not be producing warnings for people that meet or exceed the bar. I've switched this to a notice level lint. My justification for adding this is...

> I think I can get behind an INFO level lint explaining some of the complexity and danger here, as long as it clearly explains the situation. I want to...

IMO I think this is still generally valuable, and the response here was mostly stuck around the semantics of "entropy". I'll be honest, I don't think any of the arguments...

>or is this something you just happened to notice as "off" when reading the code? This is where I noticed it. Realized that it might just be some unnecessary allocations....