Anton Bachin

Flash messages: should the category be optional?

9

So, ```ocaml val put_flash : ?category:string -> string -> request -> unit ``` This allows two things: - `Dream.put_flash "just my message" request` is easier to do when getting started....

Suggestion: add ?transaction:bool to Dream.sql

6

As maybe one of the most convenient "simple" ways to do a transaction with automatic rollback on failure. cc @thangngoc89

Merge into Dream the middleware that rewrites foo/ to foo/index.html

5

There is such a middleware in [dream-serve](https://github.com/aantron/dream-serve/blob/d0bcb33f499d461e89b9a663c62fdca54e70e465/dream_serve.ml#L132-L147): ```ocaml (* Redirect requests for directories to index.html. *) let index_html next_handler request = let rec is_directory path = match path with |...

Does Dream.run clobber terminal line wrapping setting, and depend on TERM=xterm-256color?

1

`Dream.run`, if not called with `adjust_terminal:false`, sets some terminal settings, and then tries to restore them on exit (code below). - [ ] We have switched to Ctrl+C for exit....

Should there be a way to read flash messages that were set in the current request?

5

This could be useful sometimes, to use the same code that renders flash messages, to render some feedback that was generated during handling of the current request (rather than across...

cc @thangngoc89

...which sometimes clobbers exception logging output, especially since it itself sometimes raises exceptions as part of its control flow. Don't have an example ready ATM as I last observed this...

This requires (probably) patching http/af and h2. At the moment, it is possible to open connections and never send any data. The connections remain open. Such connections never even reach...

Some combination of: - [ ] A middleware that filters body chunks, accumulating their total length, and aborting responses if the length exceeds some limit. - [ ] File size...