dream icon indicating copy to clipboard operation
dream copied to clipboard

HTML Attributes that have a `:` in the middle of the name truncate everything before the `:`

Open briangwaltney opened this issue 1 year ago • 2 comments

Dream.html {|<div my:attr="test"></div>|}

The above code will produce:

<div attr="test"></div>

as output.

This prevents many features in common libraries like Alpinejs that utilize attributes with this style.

briangwaltney avatar Apr 22 '24 17:04 briangwaltney

This is an issue with Dream_livereload not with Dream. Sorry...

briangwaltney avatar Apr 22 '24 19:04 briangwaltney

Reopening, as Dream_livereload was merged into Dream (in somewhat modified form).

aantron avatar Aug 21 '24 09:08 aantron

Was able to reproduce. Most likely the same bug as in https://github.com/aantron/lambdasoup/issues/12

maxRN avatar Sep 04 '24 09:09 maxRN

Disregard my message, which I deleted. Had a fog brain moment.

aantron avatar Sep 04 '24 16:09 aantron

@maxRN would you be able to try your repro again with your PR https://github.com/aantron/lambdasoup/pull/61 (thank you!)? A pin opam pin lambdasoup --dev-repo should be sufficient IIRC, as the PR is now merged.

aantron avatar Sep 05 '24 14:09 aantron

@aantron no more lost namespaces! The bug is fixed for Dream.livereload as well.

maxRN avatar Sep 05 '24 20:09 maxRN

Many thanks!

aantron avatar Sep 06 '24 20:09 aantron

@maxRN for the repro and fix, @briangwaltney for the report and patience!

aantron avatar Sep 06 '24 20:09 aantron