Anton Bachin

Results 662 comments of Anton Bachin

On the whole, this is consistent with my experience of `opam update` being very slow (minutes) across multiple machines and OSs. I am not sure if, for example, there have...

> Problem is, that same cache in WSL must be subverted because Linux is not the only thing that can mutate the NTFS filesystem This makes me doubt what the...

My understanding is that there is already a `Lwt_unix.close` inside `Lwt_io.establish_server`. The question is that when this is a Unix domain socket, do we also need to clean up the...

> the socket can be unlinked at any time Does that mean we can proactively do the `unlink` on the socket immediately after `establish_server` returns?

It seems like it needs testing. Why would the socket file be removed? There is an open fd in the server process referring to it.

At least `Dream.run` ought to do this cleanup internally, it's supposed to be the no-boilerplate API.

And as for `Dream.serve`, I think this would be decided by whether there is ever any legitimate reason to leave the file around. Can we make the decision for the...

When doing automatic removal we should also be sure to check what happens if the socket is an abstract Unix domain socket. I guess `unlink` would fail in that case....

By the way, @toastal, would your original use case be best served by an abstract Unix domain socket, to begin with?

Seeing PR #407 deleting the file got me thinking -- do we ever need to be careful to check that the file is a socket to begin with? That is,...