Anton Bachin

Results 662 comments of Anton Bachin

Right now, it should be possible to make the `parser` sublibrary of odoc, in this repo, installable by just adding a `(public_name odoc.parser)` stanza to its `jbuild` file. ppx_odoc could...

As a further note, we ended up exposing the sublibraries as described in https://github.com/ocaml/odoc/issues/236#issuecomment-440248694. Of course, for a supported tool, we would want to fix the names, if the tool...

Amazing, thank you! I will review this gradually and I expect that I will learn a lot from it!

@Willenbrink, I'm getting ready to build this PR locally. I've found your `multipart_form-eio` package/branch from the PR in the `multipart_form` repo. I'm assuming you've done a renaming in `Gluten_eio`, etc.,...

I've done the renamings and will upload the branches later.

@Willenbrink, I'm going to occasionally push minor tweaks into this PR, or merge `master` into it. Hope you don't mind :) Please don't force push into it (and thus, please...

Reviewing the changes in API due to direct style in more detail, a note with a slight objection, as a data point for designing APIs: - Functions like `Dream.html`: https://github.com/aantron/dream/blob/edd0cd916719fc7b5291e99f581c5e69b0ac0005/src/dream.mli#L458-L462...

@Willenbrink, since you opened this PR, I've cleaned up the `Makefile` targets in `master` and upgraded and renamed the vendored libraries so that they are now consistent with `master`, Mirage,...

@Willenbrink, the build in this PR causes several warnings, which are errors in a development build. I currently work around that by adding `--profile release` temporarily to my build command....