C-Sharp-Algorithms icon indicating copy to clipboard operation
C-Sharp-Algorithms copied to clipboard

Published 20 hours ago • verified publisher icon aalhour

Add customized edge weight support for graphs.

Open zmy opened this issue 6 years ago • 7 comments

Original implementation only supports long as edge weights. This PR allows customized edge weight types while keeps default edge weight type as long/Int64.

zmy avatar Aug 08 '18 12:08 zmy

Hi @zmy,

Thanks for your contribution. Can you please refactor the tests to reflect your changes?

Cheers, Ahmad

aalhour avatar Aug 16 '18 10:08 aalhour

Hi @zmy,

Thanks for your contribution. Can you please refactor the tests to reflect your changes?

Cheers, Ahmad

Sure I am refactoring the tests, will add new commits soon :D

zmy avatar Aug 20 '18 11:08 zmy

@aalhour It seems that some unit tests themselves are not well written. When running all the tests on my local machine, only the following two tests are related to graph data structure and failed:

  • public static class GraphsBellmanFordShortestPaths
  • GraphsUndirectedWeightedDenseGraphTest

zmy avatar Aug 20 '18 17:08 zmy

Hello @zmy,

Sorry for the late reply, I was away on a long vacation. Can you maybe fix these two graphs tests?

aalhour avatar Sep 20 '18 08:09 aalhour

@aalhour Sorry for the late reply. I've just fixed related tests. Please take a look.

zmy avatar Jul 26 '19 14:07 zmy

Hi @zmy, any updates on this?

aalhour avatar Jan 22 '20 13:01 aalhour

Hi @zmy, any updates on this?

Hi @aalhour , sorry for the late reply since I'm crazy busy. I've simplified the implementation as you requested. Please take a look.

zmy avatar Jan 23 '20 08:01 zmy