Alexey Alexandrov
Alexey Alexandrov
@lannadorai Maybe you are the right owner for this after all. I think what we want here is make the perf data file conversion produce the process name / command...
https://github.com/google/perf_data_converter/blob/10d8bde947030abd2d0d9d794960210c4945a4c9/src/perf_data_converter.h#L42 is the label I mean.
We should not bring in dependency on external scripts that wouldn't be a part of the executable. pprof is a part of Go runtime distribution, so everything should be contained...
I think we shouldn't bake in a requirement that the `-http` mode generates a single HTML page. This may easily change in the future so this seems too fragile of...
There is a comment there: ``` // Try both the basename and the full path, to support the same directory // structure as the perf symfs option. ```
@egonelbre Ah, right - the volume name needs to be trimmed from m.File before appending it.
What duration of a profile and how many points / samples per second we are talking about? The profile.proto format is not designed to be an efficient timeseries storage so...
I don't anticipate working on this in pprof soon. I feel if this can be implemented as a separate tool on top of the profile.proto format - that would be...
@mhansen RE empty filenames: can you try passing `-filefunctions` flag to pprof?
I think we went back and forth on having `-functions` vs. `-filefunctions` as the default granularity in the past, so I'm not too enthusiastic about flipping the default. I could...