intermdiate_layer_matter_ssl icon indicating copy to clipboard operation
intermdiate_layer_matter_ssl copied to clipboard

Data leakage with pl-bolt implementation of v2

Open JSGrondin opened this issue 1 year ago • 0 comments

First, I want to say thanks for this paper and the code contribution, which I found quite useful and interesting.

While going through the code for the DR part, I noticed some flaws that I thought you may be interested in knowing:

  1. Most importantly, the implementation of Moco that you have been using (from pl-bolts 0.3.0) has a data leakage that was subsequently fixed in https://github.com/Lightning-AI/lightning-bolts/pull/631. The leakage comes from the fact that during your validation step, you are enqueuing validation samples that will contribute to biasing your loss calculation and update, as well as your validation metrics.
  2. Less importantly but for thoroughness, I noticed that for your baseline (mocov2 only), you did not use the same optimizer schedule.

JSGrondin avatar Mar 09 '23 16:03 JSGrondin