Unshaky icon indicating copy to clipboard operation
Unshaky copied to clipboard

Filtering sometimes doesn't work

Open sky417 opened this issue 4 years ago • 1 comments

On macOS 11.5.2, unshaky 0.7.0.

Currently I have 55ms for global setting and 130ms for Space.

For some reason, the chattering doesn't get filtered for unknown reason. Here's a couple of samples:

1631548154.279290 Key( 40| 49|         Space|         0|130) E(10)
1631548154.396071 Key( 40| 49|         Space|         0|130) E(11)
1631548154.401034 Key( 40| 49|         Space|         0|130) E(10)
1631548154.404899 Key( 40| 49|         Space|         0|130) E(11)

The delta from keyup to keydown was only ~5ms, yet still registered.

1631548383.173862 Key( 40| 49|         Space|         0|130) E(10)
1631548383.231955 Key( 40| 14|             E|         0| 55) E(11)
1631548383.274003 Key( 40| 49|         Space|         0|130) E(11)
1631548383.278947 Key( 40| 49|         Space|         0|130) E(10)
1631548383.279698 Key( 40| 49|         Space|         0|130) E(11)

The delta here was about 4.9ms, and registered.

Working log:

1631548512.333682 Key( 40| 49|         Space|         0|130) E(11)
1631548512.342858 Key( 40| 49|         Space|         0|130) E(10) DISMISSED
1631548512.342986 Key( 40| 49|         Space|         0|130) E(11) DISMISSED

Worked fine in this case, ~9ms delta.

Is there any known issue ?

sky417 avatar Sep 13 '21 16:09 sky417

@sky417 this is pretty strange. From the log, my guess is it is somehow triggers the special logic:

I cannot remember too much details. Will try to re-visit this when I have time

https://github.com/aahung/Unshaky/blob/feac0093d0d823c183a6b83800a399a633b448cf/Unshaky/ShakyPressPreventer.m#L182-L196

https://github.com/aahung/Unshaky/blob/feac0093d0d823c183a6b83800a399a633b448cf/Unshaky/ShakyPressPreventer.m#L220

aahung avatar Sep 28 '21 11:09 aahung