Unshaky icon indicating copy to clipboard operation
Unshaky copied to clipboard

Log number of OK keypresses

Open Coder-256 opened this issue 5 years ago • 5 comments

Is your feature request related to a problem? Please describe. I wonder what percentage of presses are shaky for each key. For example, E is at the top of my list, but that's probably because I use it a lot

Describe the solution you'd like I wish Unshaky logged the number of all keypresses, both the overall total and totals for each key. Maybe the Statistics window could look something like:

Key Dismissed % Dismissed Ignored Total
E 10% 20 180 200
N 6% 5 75 80
... ... ... ... ...

And the dropdown could say, "Dismissed 25 shaky presses... (8.93% of 280)"

Describe alternatives you've considered The table format and message text could change.

Additional context N/A

Coder-256 avatar Feb 03 '20 18:02 Coder-256

Thanks! Nice feature to implement!

aahung avatar Feb 03 '20 18:02 aahung

Exposed per key counts and statistics are potentially harmful; for example comparing key counts before and after a password entry (eg. asking someone to unlock their device twice). If https://github.com/aahung/Unshaky/issues/25 is not fixed this seems like less of an issue (only affecting non-password secrets).

sburford avatar Apr 30 '20 05:04 sburford

that's definitely something we should consider here. potential malware might rely on monitoring unshaky's log (which requires much lower permission than listening to key press itself) to log the keypress.

aahung avatar May 01 '20 22:05 aahung

Maybe make Shaky log available to root only, and require elevated privileges to look at per-key statistics.

toriningen avatar Jul 17 '20 05:07 toriningen

Maybe make Shaky log available to root only, and require elevated privileges to look at per-key statistics.

Unshaky does not require root permission to launch right now, I don't think it is worth to do this.

aahung avatar Dec 13 '20 01:12 aahung