Evan Mattson

Results 308 comments of Evan Mattson

@wpdarren this should be ready for another pass on `main` 👍

@wpdarren the toggle will only be disabled if the associated measurement ID for the selected property matches the existing tag. I tested this locally and it seems to work as...

## Approval ⚠️ I can't test this on an M1 but @tofumatt already confirmed in the initial review that it worked for him. However, I'm getting failures on my Intel...

Closing this as done as a first step. Will open a new issue to see about addressing the failures we're seeing locally.

@FlicHollis I've opened https://github.com/google/site-kit-wp/issues/5824 as the follow up for this sprint which is already assigned 👍

> A possible solution could be to use something like: @jimmymadon oAuth requests made by the Google Client use Guzzle internally so we can't use the `pre_http_request` filter like we...

@felixarntz does the 2nd point of the AC sound good to you? I noticed the only place we delete this is in `Authentication::inline_js_base_data` which seems incorrect if the token was...

@felixarntz, yes this is about updating saved v1 statuses in the AdSense settings. Not sure if sites that aren't connected yet would benefit from this or not but connected sites...

@felixarntz thinking about this a bit more, the connected state is based on the `(account|site)SetupComplete` options, [which are already migrated from the v1 `setupComplete` option](https://github.com/google/site-kit-wp/blob/c52372a7d671838094a5dde70d437bd36d4370c4/includes/Modules/AdSense/Settings.php#L118-L123). So as long as the...