Evan Mattson

Results 308 comments of Evan Mattson

@techanvil the ACs here look like a good start. However, since this is somewhat of a batch request, there are some additional considerations that should probably be included here as...

Thanks @techanvil, this looks good and I think we can move forward with it. One thing I would flag for the IB (and its review) is the `ModuleRecoveryAlert` which reads...

@felixarntz I spent some time looking into this today related to another issue and was able to get it working in a way that seems normal in the browser with...

@felixarntz @tofumatt please assign back to me when ready to proceed.

It is still needed, but has lagged a bit in priority. The scale of the changes needed and quirks to work through along with familiarity with the datastore makes it...

@techanvil thanks for digging into this, the added context is really useful! Looking at the changes to the tests in Gutenberg, I wonder if we could use the same approach...

## Approval ❌ The service URL for AdSense is not being constructed in the same way as before as noted above. It's now applying the `path` as a URL hash...

@wpdarren please flag regressions like this before approving as this change is not behind a feature flag. It's good that you raised this otherwise it very likely could have been...

@felixarntz do you think we need UX input here? Also, most (if not all?) Google services show the user's name as well (not just the email) but we only have...

> Regarding the user's avatar, I don't think we need to enforce it to be 80x80, IMO the way it currently is is fine. I would suggest we make this...