jschardet icon indicating copy to clipboard operation
jschardet copied to clipboard

Wrong guess encoding as Windows 1252

Open Yanpas opened this issue 7 years ago • 2 comments

See https://github.com/Microsoft/vscode/issues/33720

Test case

#!/bin/sh

foo() {
	echo "starting …"
}

Ellipsis symbol makes vscode guess cp1252. UTF8 should have higher priority IMO

Yanpas avatar May 19 '18 15:05 Yanpas

See https://github.com/Microsoft/vscode/issues/33720#issuecomment-398412202

Yanpas avatar Jun 19 '18 19:06 Yanpas

I built vscode-oss with jschardet 2.2.1 and test this case, vscode guess the file as UTF-8 correctly. I think patch #57 and #59 already fixed this issue. @aadsm maybe this issue can be closed?

lingsamuel avatar Jul 02 '20 02:07 lingsamuel