PacketWrapper icon indicating copy to clipboard operation
PacketWrapper copied to clipboard

Please support to 1.12

Open JackWisdom opened this issue 7 years ago • 1 comments

in spigot 1.12 PacketPlayOutWindowItems returns List<ItemStack> instead of Array<ItemStack> please change your code public ItemStack[] getItems() { return handle.getItemListModifier().read(0).toArray(new ItemStack[0]); }

JackWisdom avatar Feb 18 '18 10:02 JackWisdom

This project was last updated 4 years ago and currently on Minecraft version 1.7.2.

A fork of this project seems to still be actively developed and is currently up to version 1.12.2: https://github.com/dmulloy2/PacketWrapper

Also when suggesting line edits on GitHub, you can actually go edit the files your self, make a commit on a forked branch and create and issue requesting to merge in your changes. Makes it easier to keep track of context and see what the edits would imply and removes any confusion, instead of having to manually find the file you are talking about look through the code to find where in the file you suggest the edit.

kristianvld avatar Feb 19 '18 01:02 kristianvld