laravel-saml2 icon indicating copy to clipboard operation
laravel-saml2 copied to clipboard

Support for Lumen

Open DiederikvandenB opened this issue 8 years ago • 21 comments

Quick question, are you planning on supporting Lumen anytime in the near future? There are only a few small issues to be ironed out I believe.

DiederikvandenB avatar Jun 20 '16 11:06 DiederikvandenB

I dont have the time now to do that, but if anyone wants to make a fork/branch/PR is welcome

aacotroneo avatar Jun 20 '16 14:06 aacotroneo

Do you have a list of tasks to be done to support Lumen. I may be able to take a look at this in the coming weeks.

ChinmayPatel avatar Aug 15 '16 14:08 ChinmayPatel

Sorry @ChinmayPatel I've been away of php for a while.. I've never used Lumen at all. I imagine the hooks should be similar.. this library just grabs configuration and pass control to one-long at proper times

aacotroneo avatar Aug 17 '16 12:08 aacotroneo

Hey @aacotroneo. I'll give it a try in the coming weeks if we decide to go with SAML. Thanks for the prompt response.

ChinmayPatel avatar Aug 17 '16 17:08 ChinmayPatel

I'm also very interested in using this for a Lumen project, so if anyone's figured it out, I'd gladly hear about your experiences using it

denizdogan avatar Sep 22 '16 09:09 denizdogan

Hey there, anybody made this to support lumen or does anybody have any list what we need to do to get this working on lumen ?

durimjusaj avatar Jun 22 '17 08:06 durimjusaj

Of couse it never hurts with Lumen support, but imho Lumen is best for simple, session-less services, and if I needed SAML I would go for Laravel instead. From Matt Stauffer: "Lumen is built for microservices, not so much for user-facing applications (although it can be used for anything.) " (https://mattstauffer.co/blog/introducing-lumen-from-laravel)

danmichaelo avatar Jun 22 '17 12:06 danmichaelo

Has Lumen support been released yet? Or maybe someone made the necessary changes in order to implement this package on Lumen ? I am really looking forward to implement it in an existing Lumen microservice

lelandpalmer avatar Jun 08 '19 03:06 lelandpalmer

Hey, I also needed Lumen version and forked this repo to create another -https://packagist.org/packages/ibpavlov/lumen-saml2. I prefer separate repo because of the tag versioning.

@danmichaelo You are right about the microservices, but there are other good use cases. We use Lumen with a legacy system to enhance it, add new features and clean the code by using Illuminate packages.

ibpavlov avatar Aug 22 '19 08:08 ibpavlov

@ibpavlov do you have any working sample lumen project for the same if yes please share.Thanks in advance.

Rushi1807 avatar Dec 24 '19 14:12 Rushi1807

@ibpavlov do you have any working sample lumen project for the same if yes please share.Thanks in advance.

No. I use it in a private project. But this ia a good idea. I'll try to create one soon.

ibpavlov avatar Dec 25 '19 10:12 ibpavlov

@ibpavlov We are unable configure your package, we followed all steps from read me still facing issue in setting up with one login if you have any other related documents with setup please help!

Rushi1807 avatar Dec 25 '19 12:12 Rushi1807

Hey. I've used https://github.com/onelogin/php-saml documentation to setup this package. We are using Microsoft Azure AD with Saml 2 in our project.

ibpavlov avatar Dec 29 '19 11:12 ibpavlov

Codecov Report

Merging #29 (c76953f) into master (6fe523e) will decrease coverage by 0.27%. The diff coverage is 81.39%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
- Coverage   98.35%   98.09%   -0.27%     
==========================================
  Files          17       17              
  Lines        2861     2880      +19     
==========================================
+ Hits         2814     2825      +11     
- Misses         47       55       +8     
Impacted Files Coverage Δ
R/genetic_algorithm.R 95.43% <45.45%> (-1.00%) :arrow_down:
R/fitness.R 97.59% <50.00%> (-2.41%) :arrow_down:
R/calculate_energy.R 100.00% <100.00%> (ø)
R/crossover.R 100.00% <100.00%> (ø)
R/grid_area.R 100.00% <100.00%> (ø)
R/plots.R 98.71% <100.00%> (+0.09%) :arrow_up:
R/visibility.R 97.40% <100.00%> (-0.63%) :arrow_down:
R/windfarmGA.R 91.96% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Rushi1807 avatar Dec 31 '19 10:12 Rushi1807

@ibpavlov we are facing Logger and Session issue in saml2Controller file. please help!Thanks

@Rushi1807 You can write your own controller and change config for 'saml2_settings.saml2_controller'. Methids acl and sls just use the logger for debugging purposes. But some session storage is required here to keep the user authenticated.

ibpavlov avatar Jan 01 '20 10:01 ibpavlov

@ibpavlov Can you help me with this error!Thanks sprintf(): Too few argumentsArray ( [error] => Array ( [0] => invalid_response ) [last_error_reason] => sprintf(): Too few arguments )

Rushi1807 avatar Jan 02 '20 10:01 Rushi1807

@Rushi1807 You have to check your code for sprintf usage and check the arguments. Or you should provide more information.

ibpavlov avatar Jan 03 '20 13:01 ibpavlov

@ibpavlov Are there any extra configurations needed in the same package for Microsoft ADFS implementation. It worked for OneLogin toolkit Thank you

Rushi1807 avatar Jan 24 '20 04:01 Rushi1807

@Rushi1807 If it supports Saml2 protocol, then yes. The configurations itself are the same for all different Identity providers (IDP) with SAML2. We have used it with Microsoft Azure AD.

ibpavlov avatar Jan 24 '20 16:01 ibpavlov

any plan to support for lumen? this is much better to integrate in micro framework since this is not needed to use other web component in laravel

lloricode avatar Feb 25 '20 00:02 lloricode

Any progress with this issue?

arturslogins avatar Feb 02 '21 09:02 arturslogins