dnsdock icon indicating copy to clipboard operation
dnsdock copied to clipboard

Labels for tags and name override each other depending on ordering

Open febbraro opened this issue 8 years ago • 5 comments

It appears that com.dnsdock.tags and com.dnsdock.name cannot be used together as they populate the same space in the domain name. It is further complicated by the fact that which ever one is defined last wins. Is there a reason we don't set it up such that tags and name populate different parts of the domain name? Also, the docs are unclear about what to use when, and appear contradictory.

If you are open to changing a bit of how the names are built I can work on a PR and doc updates.

When looking at all the options this seems to make the most sense to me. I'm wondering what you think.... <tag>.<name>.<region>.<image>.<environment>.<domain>

febbraro avatar Dec 20 '16 22:12 febbraro

Also, it looks like you can specify many tags, comma separated, but it will only ever use the first one. Was the eventual intention if there were multiple tags that it would use the tags and create an entry per tag?

febbraro avatar Dec 21 '16 18:12 febbraro

Hi ! You're completely right about this issue ! I am OK with your proposal of having multiple alias with the scheme you propose. Feel free to do a PR. If you can't tell me I'll do the modifications

aacebedo avatar Dec 22 '16 07:12 aacebedo

Sorry for the delay here. I'm working on something and hope to put a PR together by the end of the week. Working through learning the right way to develop dnsdock w/ rocker, etc.

febbraro avatar Jan 09 '17 19:01 febbraro

PR #99 was submitted to address this issue.

febbraro avatar May 11 '17 13:05 febbraro

Any feedback on this PR/Issue?

febbraro avatar May 30 '17 20:05 febbraro