Ahmed AbouZaid comments

Results 249 comments of


                                            Ahmed AbouZaid

fix: krm exec function working dir

@KnVerey @natasha41575 could you please take a look at this PR? It's ready.

fix: krm exec function working dir

@KnVerey @natasha41575 could we at least run the CI pipeline to make sure everything as expected :sweat_smile:

fix: krm exec function working dir

@natasha41575 Yes, I will try to finish it over the weekend.

fix: krm exec function working dir

@KnVerey @natasha41575 I believe that we are ready to go. I've renamed the deep copy method to be more specific and added a test for it.

fix: krm exec function working dir

/assign @natasha41575

fix: krm exec function working dir

I just fixed the doc comment for the new methods.

fix: krm exec function working dir

I've addressed all comments. So we are ready to go. :heavy_check_mark: I will rebase and update the commit messages once no more changes are required. I see that there is...

fix: krm exec function working dir

@annasong20 thanks for reviewing this PR :ok_hand: The last step was to rebase and squash the last 2 commits to have a meaningful message :sweat_smile:

commonLabels in components should be scoped to component level

I just came to open an issue for the same problem. It's not clear to me why the component's `commonLabels` overwrites the label of the resource :thinking:

commonLabels in components should be scoped to component level

That's probably the same as #3770 but still not answered. TBH, for me, it's confusing behavior!