Aaron Abbott
Aaron Abbott
Thanks for trying out the metrics SDK 🙂 The difference between metrics and trace/logs here is that all the metrics come in at once and there is no batching in...
As a place to configure the batch size, and then the `PeriodicExportingMetricReader` will call the exporter once per batch. @srikanthccv would you prefer to just have the individual exporters handle...
> It would be great to have this kind of behavior but I think we should also be able to configure a "max batch size" in the OTLPMetricExporter. @overmeulen any...
Thanks, I'll assign you the issue. We haven't implemented the HTTP exporter yet, so that seems reasonable to me.
Just adding the discussions from the PR #2809 which adds a `max_export_batch_size`. @overmeulen said > I don't really have a recommendation for the max_export_batch_size, it highly depends on the type...
See also https://github.com/open-telemetry/opentelemetry-specification/issues/2772
@overmeulen do you mind sharing what you said in the SIG here?
Moving some discussion from the PR here: > ```py > def _export( > self, > data: TypingSequence[SDKDataT], > timeout_millis: Optional[float] = None, > ) -> ExportResultT: > if timeout_millis is...
If this helps move things forward, I had a [draft PR](https://github.com/aabmass/opentelemetry-proto/pull/3/files) adding a linter to detect wire (binary and json) breaking changes to this repo. I am happy to revive...
✋ I can take ownership of this issue but also not sure when I'll get around to a fix. If anyone would like to submit a PR, please drop a...