Aaron Abbott

Results 302 comments of Aaron Abbott

> there was a statement that OTEL desired to support only 1 version of protobuf, no? I hope it will be `protobuf 6` soon 🎉 > > The statement appeared...

> I have time for this tomorrow, sure. Did you already start on this? If not, I already have a fix I can push.

@emdneto PTAL, I added separate tox targets for oldest+latest supported dependencies for `opentelemetry-proto` and `opentelemetry-exporter-otlp-proto-grpc`, generated with `uv pip compile`.

No worries, this was filing a bug for a sample related to my team. It's this sample https://github.com/GoogleCloudPlatform/golang-samples/tree/main/run/custom-metrics

The opt-out change has been out for a while and I haven't heard any complaints. Maybe we can consider removing this in after the upcoming release.

With some scripting and modifying pylint to print out files analyzed following [this SO](https://stackoverflow.com/questions/43076534/report-filename-that-is-being-checked), I think there are 51 files not being linted: Show files ``` opentelemetry-api/tests/attributes/test_attributes.py opentelemetry-api/tests/baggage/propagation/test_propagation.py opentelemetry-api/tests/baggage/test_baggage.py opentelemetry-api/tests/logs/test_logger_provider.py...

I think ruff recursively finds all files in the filesystem so would be checking them. It doesn't try to do fancy inference so doesn't need to be aware of the...

Maybe this is the culprit https://github.com/pylint-dev/pylint/issues/3944 EDIT yup that actually fixes it. I tried deleting `__init__.py` files and pylint correctly discovers the test files.

> I tried implementing this in the [contrib repo](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2658), apparently it is also important that `pylint` is run in the directory that contains the directory being checked. I don't think...

I'll take this PR over, will try to address the comments soon