Alec Bills
Alec Bills
Yes. But that means that the assumption is that the overhang doesn't participate at all, which I doubt is true, though surprisingly, I can't find a 3d study revealing the...
> * allow "Vmin" and "Vmax" as limits (and "Imax", "Tmax", etc)? > * specify safety limits that make the experiment stop completely? Adding to this, it might be nice...
> This would make it annoying to specify initial SOC though. Don't we use `Open-circuit voltage at 0% SOC [V]` and `Open-circuit voltage at 100% SOC [V]` for that? And...
> @aabills might be good for you to review this one since you've been looking at the composite code a lot recently I'm going to review this after a meeting...
> My opinion is that we should remove all of these default options that change based on other options and instead users should explicitly choose all the options they want....
Thanks for taking this on, @vidipsingh . I can't help but notice that there are a bunch of changes made here that are unrelated to this issue. Perhaps they are...
> I see why you want to do this but it can be a bit of a shock to people new to PyBaMM. I was just mentoring someone who was...
> > Thanks for taking this on, @vidipsingh . I can't help but notice that there are a bunch of changes made here that are unrelated to this issue. Perhaps...
I think this is mostly closed by #4698, though its hard to tell if I got everything.
@mohammedasher Can you check and see if what you were intending to fix here works on pybamm 25.1.1?