Adam

Results 337 comments of Adam

Hi @abstratt. Thanks again for your efforts. It's not clear from your screenshot, but I think you commented out the `.filter { artifact -> ... }` section? If so, I...

> Hi @aSemy, sorry if my response was too vague. > > The main point I intended to convey is that as long as you stay clear from using API...

@abstratt From what I understand from your explanation, this is the relevant part of the above reproducer that isn't preserving task dependencies: ```kotlin // buildSrc/src/main/kotlin/CoolDependencyContainer.kt // ... val incomingArtifacts =...

> please feel free to open a specific feature request for API that would allow you to write code that behaves correctly (without resorting to eager realization). I have opened...

~Would you consider splitting them out into a separate subproject? It would help with making the Gradle Plugin more idiomatic, being able to test them in isolation, and keeping user's...

I hope you feel better soon @qoomon! I think what might work is putting every JGit calls inside a [`ValueSource`](https://docs.gradle.org/current/javadoc/org/gradle/api/provider/ValueSource.html), to be computed lazily. That should allow Gradle to fingerprint...

Ah I thought the Action class was a significant Gradle object, but thinking about it, it's not. It just needs to be a lambda parameter. In Kotlin it would be...

Ah I see... I'll see if I can make a draft PR as a demo. I think using `@HasImplicitReceiver` is the start of improving it ```java import me.qoomon.gitversioning.commons.GitSituation; import me.qoomon.gradle.gitversioning.GitVersioningPluginConfig.RefPatchDescription;...

> I'll try to implement it in Java and then I'll migrate the project to kotlin hey @qoomon, how would you feel about picking this up again? :) I'd like...

I have done some pondering and I think the best way forward is to essentially create a new version by changing gradle-git-versioning-plugin to be a Gradle Settings plugin. https://stackoverflow.com/questions/69149466/gradle-7-2-how-to-apply-a-custom-gradle-settings-plugin ```kotlin...