POE-ItemInfo
POE-ItemInfo copied to clipboard
aRTy42
Unique Items original value display
This seems to happen for every unique item that have range values. The file is properly read since the tooltip shows the range but it fails to show the original value.
Unique data is completely read from a file, just by the name of the item. The script does not compare the affixes.
The potential problem with trying to include the personal rolls is that GGG changed the affix order on uniques every now and then or that the wiki has a different ordering, so we can't be sure that the lines read from the file are exactly corresponding to the lines on the item, so the inserted number might be wrong. If we read all the affixes from the ingame item and only add the roll ranges from a file, we might add them to the wrong line. Either way, I don't see an easy way to be completely safe. That's why rolls are not included yet.
You'd have to match the mod names, this of course bears the risks of having old data because GGG changed something. But that's what I'm doing for TradeMacros advanced search, that's the main reason for updating those files at every script start from the repo (no release neccessary).
You can't just parse uniques like they are rares? (Or is that what Eruyome is suggesting?)
Uniques have lots of stat lines that are special. The parsing for rares is done by matching the stats on an item to text pieces. There is no fancy method involved, the script uses about 3000 lines of code to account for everything.
Making that work for uniques would require some sort of file or database to look everything up or match against. You can certainly do that, but it is basically a complete rework of the current unique handling and introduces the need for background updates on script start etc. which comes with more opportunities for issues.
The benefit does not seem big enough to me to start such a rework.
Assuming someone provided an always perfect database of uniques for current patch. Would the effort involved in rewriting the parser be worth it? I haven't looked into this part of the script yet, but this has been an issue I've been wanting to fix too. Could you separate unique and rare parsing completely?
They are already separated. The unique "parsing" is just loading prepared data from the uniques.txt file by item name. That's the point here. Adding features like reading the values ingame would require a completely new method for handling uniques.
Ahh I see now i misunderstood, I should have looked first. It's an entire new project. Thank you for your efforts!
Came here to suggest this. If its too much work to match mod names on wiki and item being checked then maybe just display all the mods from the item with their text on the right side of wiki data without trying to match them. With some kind of separator like line of '|' symbols. Will make comparing much faster (especially for people who use fixed position of a tooltip) What do you guys think?
