RandLA-Net-pytorch icon indicating copy to clipboard operation
RandLA-Net-pytorch copied to clipboard

squared distances

Open AmnonDrory opened this issue 4 years ago • 2 comments

First of all thanks for sharing you RandLa-Net implementation, it is very helpful. I've noticed that the distances returned by knn() are squared (at least when using torch_points_kernels). In the paper they mention using non-squared distances, and from a quick look at the tensorflow code, it seems they indeed use non-squared distances. Hope this is helpful. Thanks, Amnon Drory

AmnonDrory avatar Sep 09 '20 11:09 AmnonDrory

Thanks Amnon for your comment !

Indeed, this could be an important difference that impoverished our results. Did you noticed any improvement in results with the non-squared distance ?

Thibaud

Thibaud-Ardoin avatar Sep 09 '20 14:09 Thibaud-Ardoin

@AmnonDrory , Did you manage to try using un-squared distances? was there an improvement? I've noticed that the torch_point_kernels knn returns automatically squared distances, so I'm wondering if there is any other way fixing this issue rather than just taking the square root of distances. Thanks

eyalol avatar Jan 05 '21 12:01 eyalol