kinesis-producer icon indicating copy to clipboard operation
kinesis-producer copied to clipboard

Use different defaults for different architectures to avoid integer o…

Open andrewstucki opened this issue 5 years ago • 3 comments

Fixes https://github.com/a8m/kinesis-producer/issues/4 by specifying two different aggregation counts, 1 for 32 bit platforms, one for 64 bit.

andrewstucki avatar Oct 16 '18 20:10 andrewstucki

Hey @andrewstucki, thanks for your contribution. I'm not sure I want to add these extra files just for one variable. What do you think about adding something like this:


var maxAggregationCount = math.MaxInt32
if strconv.IntSize == 64 {
  maxAggregationCount = math.MaxUint32
}

Update: my other suggestion is to just set it to math.MaxInt32 and add an explanation in the comment above (see the current comment).

a8m avatar Oct 20 '18 10:10 a8m

Any update on this @andrewstucki?

a8m avatar Nov 01 '18 09:11 a8m

Any progress here. this is still broken on 32 bit platforms.

magiconair avatar Mar 05 '21 13:03 magiconair