react-webcomponentify icon indicating copy to clipboard operation
react-webcomponentify copied to clipboard

Published 20 hours ago • verified publisher icon a7ul

Incompatibility warning when upgrading to React 18

Open ududsha opened this issue 3 years ago • 3 comments

I have upgraded our app with React 18 and got the below warning since I am using react-webcomponentify.

image

Since React 18 is not supporting ReactDOM.render, we are getting this. Instead of that we should use createRoot API and its mentioned in their upgrade guide. I suggest to upgrade the library to support React 18 with proper backward compatibility with older versions.

I would love to contribute on that. Let me know if you have any nicer suggestion or any plans already in mind @kopach @a7ul .

ududsha avatar Apr 08 '22 07:04 ududsha

Awesome @ududsha can you maybe raise a pr for this?

a7ul avatar Apr 08 '22 07:04 a7ul

Sure Let me work on it! Thanks @a7ul

ududsha avatar Apr 08 '22 07:04 ududsha

Hi @a7ul, I have upgraded the library with React18, but it seems still have issues when we are going to use in another project. Really appreciate if someone can help checking this => https://github.com/ududsha/react-webcomponentify/commits/feature/upgrade-to-react18

ududsha avatar Apr 22 '22 02:04 ududsha