hag icon indicating copy to clipboard operation
hag copied to clipboard

Move existing flavortext to flavortext module

Open JohnathonNow opened this issue 6 years ago • 2 comments

There are many pieces of dialog throughout the code that should be moved to the flavortext module. In addition to keeping things organized, it also makes potential translation easier if anyone eventually ever cares about that.

JohnathonNow avatar Oct 11 '19 04:10 JohnathonNow

Can you elaborate with an example, I am a little confused, would love to take this up

adinalini avatar Oct 18 '19 12:10 adinalini

Right now we have user displayed strings throughout the entire codebase, such as here. I think it would be better for that line to be changed to

add_action(FT_HAG_SUMMON_SNEK);

and then a line added to flavortext.h that says:

#DEFINE FT_HAG_SUMMON_SNEK ("The old hag summons a dangerous snek!")

with this done to all displayed strings. Formatted strings are a little more tricky, though.

JohnathonNow avatar Oct 22 '19 22:10 JohnathonNow