helios icon indicating copy to clipboard operation
helios copied to clipboard

feat: Standardization of responses according to eth_rpc specs for eth_ methods related to byNumber and byHash

Open phklive opened this issue 1 year ago • 1 comments

The methods: eth_getBlockByNumber eth_getBlockTransactionCountByNumber eth_getBlockByHash eth_getBlockTransactionCountByHash

Some respond with null and some respond with an error if passed a block that has not been synced by helios.

But in the eth_specs we can see that the normal behavior in that case should always be returning null.

The idea is to standardize the responses of these methods to make them always repsond with null in case an unsynced block is passed.

It could also be a good idea to add a print / log "block has not been synced by helios client" or something following those lines.

phklive avatar Apr 22 '23 19:04 phklive

@phklive Thanks for calling this out. I will get this implemented

giovannivignone avatar Apr 30 '23 05:04 giovannivignone