helios icon indicating copy to clipboard operation
helios copied to clipboard

implement logging rpc methods

Open ncitron opened this issue 2 years ago • 5 comments

We currently don't have any of the rpc methods related to fetching logs implemented. There seems to be a lot of them, and I'm not sure which ones dapps use the most (it seems dapps are using logs less and less nowadays). I think the best plan is to use a bunch of dapps and keep track of which of the log methods they are using and implement them.

ncitron avatar Sep 12 '22 16:09 ncitron

Hi @ncitron, I'm new to rust in general, but I just saw the project and good first issue tag, and I'd like to contribute in any way. I'll start researching what rpc methods other dapps use for fetching logs.

AlbionaHoti avatar Nov 08 '22 15:11 AlbionaHoti

Hey @ncitron @AlbionaHoti,

I was looking at this issue just today, just after trying helios for the first time :)

I think we can start by the implementation of:

Let me know @AlbionaHoti if you want to start working on it and @ncitron how i can help. Otherwise, I'm happy to take over :)

simon-saliba avatar Nov 08 '22 16:11 simon-saliba

That sounds great! I think eth_getLogs is the more used one, so that would probably be best to start with. The filter one's are a bit more complex, since they are actually statefull, where users add and remove filters, then can query them. I don't think they get used as much as well.

@AlbionaHoti @simon-saliba happy to see either (or both) of you work on this.

ncitron avatar Nov 08 '22 16:11 ncitron

Hey, I opened a draft PR. I'm not sure if we need some kind of "proof" for logs, as it is done for accounts for example.

simon-saliba avatar Nov 12 '22 12:11 simon-saliba

+1 for eth_getLogs and chiming it to say that logs are a very important mechanism for fully decentralized apps

@ncitron

(it seems dapps are using logs less and less nowadays)

This only because more and more web3 app relies on third party servers but truly decentralized app will make use of eth_getLogs themselves

Currently working on in-browser generic indexer to faciliate this, see : https://github.com/conquest-eth/ethereum-indexer (which use eth_getLogs)

wighawag avatar Nov 26 '22 05:11 wighawag