Alexandre Ardhuin

The only context that is safe to make the changes is when the call site is inside an async body. Without `future.then(...)` or `future.catchError(...)` (like `f5`) there's no problem to...

The only cases I can think of are : ```dart returning_future() { Future asyncFunction() => throw Error(); Future f1() async => Future.value(); // LINT Future f2() async // LINT {...

I made a rule `avoid_shadowing` available in https://github.com/a14n/linter/tree/avoid_shadowing branch. The rule is perhaps a little too aggressive. It adds a lint if there's already a similar name visible (see [test](https://github.com/a14n/linter/commit/f56c8648d0bfed047196c6e438bf95c459a4346a#diff-d1b0201e560207a7be25111c139bf49eR1))....

Similarly I had the mixed feeling about the lines linted. However I can imagine some people happy with this rule as it is today. If I look at Checkstyle in...

@jakemac53 I just opened #872 to add an `avoid_shadowing` rule. It would be great if you can run this ne rule on your project and see if it is fine...

With the exclusion pattern `var x = this.x;` Flutter has the 82 below lints (121 without the pattern). - [dev/bots/analyze-sample-code.dart, line 212, col 24](https://github.com/flutter/flutter/blob/159db5ca442f9891a24f2a4273e2fad0884b1d2a/dev/bots/analyze-sample-code.dart#L212) - [dev/tools/dartdoc.dart, line 108, col 22](https://github.com/flutter/flutter/blob/159db5ca442f9891a24f2a4273e2fad0884b1d2a/dev/tools/dartdoc.dart#L108)...

I'm not really tempted by this lint. Especially when the literal is used only once. This makes readability harder IMHO because you end up jumping to variable declarations all the...

Ok, thanks for the clarification. I thought it was a general lint that would have been activated by default. Sorry for the noise ;)

Do you have a particular value of decimal to reproduce this error?

I am hesitating on this. On one hand it could simplify operations. But on the other hand, it implies to use `dynamic` as type annotation for argument and skip all...