react-easy-print Refactor/class to func component

Refactor/class to func component

Open Vitao18 opened this issue 4 years ago • 6 comments

Closes #43

Nov 09 '19 21:11 Vitao18

@a-x- can you help us review this?

Nov 12 '19 02:11 sibelius

I'll check the comments and suggestions and work on the changes later Thanks for the valuable input, very glad to help

Nov 23 '19 15:11 Vitao18

https://github.com/a-x-/react-easy-print/pull/44#pullrequestreview-321913619, @sibelius: I don’t think this influence the react devtool

Heh, looks you're right

demo: https://pncwt.csb.app/

It's because of babel preset react: Screenshot 2019-11-23 at 18 23 22 👆

Nov 23 '19 15:11 a-x-

@a-x- any progress on this?

anything we can do to help?

Feb 03 '20 13:02 sibelius

@a-x- Hey, anything I can do to help to get this merged? I'll check the refactor again to see if there's something missing

Just let me know :)

Jun 24 '20 15:06 Vitao18

can we merge and release a new version?

it would be cool to add some react-testing-library tests after this

Jun 24 '20 15:06 sibelius