Alexandra Sidorova

Results 17 comments of Alexandra Sidorova

@zhangYiIntel also I'd like to suggest you to rebase the branch to the master

@dmitry-gorokhov @IvanNovoselov I have applied your comments. Take a look please one more time Also I'd like to notice that I have rewritten logic of `Convert` insertion and reset of...

@chenhu-wang I was investigating problems on Win on your PR and I have found out that `StoreEmitter` works differently on OSs for 1 store byte. You added changes for 1byte...

Could you please add tests to check that biases aren't fused into `Subgraph`? We have almost the same [test](https://github.com/openvinotoolkit/openvino/blob/master/src/tests/functional/plugin/cpu/shared_tests_instances/snippets/conv_eltwise.cpp) for `Convolution`

@ilya-lavrenov @EgorDuplensky guys, could you take a look please? Thanks!

Review status: - Need to finish `SnippetsMarkSkipped` [impl](https://github.com/openvinotoolkit/openvino/pull/23180#discussion_r1581747971) and add [tests](https://github.com/openvinotoolkit/openvino/pull/23180#discussion_r1581749034) that cover this pass. - Need to resolve the [problem](https://github.com/openvinotoolkit/openvino/pull/23180#discussion_r1579117839) with incorrect layout choice. In the progress. Waiting for...

@chenhu-wang could you take a look please as author of these implementations? Thanks in advance!

@chenhu-wang thanks a lot for the review and help! @dmitry-gorokhov could you please take a look as well? Thanks in advance!

TODO: Apply the comment from https://github.com/openvinotoolkit/openvino/pull/21881/commits/d5436298c4daef07e73d0405453ea16d195c551a when the PR https://github.com/openvinotoolkit/openvino/pull/21881 is merged

@v-Golubev @IvanNovoselov guys, take a look please. You may review only last commit [849fba8](https://github.com/openvinotoolkit/openvino/pull/21895/commits/849fba826ba96c6b81fdd0f8e63052e70c20e783)