osm2streets icon indicating copy to clipboard operation
osm2streets copied to clipboard

Add turn movements

Open BudgieInWA opened this issue 1 year ago • 3 comments

We don't need all of this before merging, but here's the plan so far:

  • [x] Rename Movement -> Turn (road level), add TurnMovement (lane level)
  • [x] Calculate TurnMovements for degenerate (2 road) intersections
  • [ ] Calculate movements for IntersectionKind::Connections with more than two roads.
  • [ ] Do some default allocations for arbitrarily complex intersections.
  • [ ] Add TurnKind to determine what kind of lane markings the TurnMovements get.
  • [x] Render "turn guide" lane markings for "turn" turns.
  • [ ] Render ordinary lane markings for "continuation" turns (ideally, reusing the normal logic).

This is making some good progress towards lane level movements. In fact, some movements are calculated and drawn! I added the movement centrelines in post, the left edge of the movements are being drawn:

image

We need angled road ends, #95, to draw these markings properly.

BudgieInWA avatar Mar 05 '23 11:03 BudgieInWA

Really cool to see this!

Not that I'm likely to play with the JOSM side soon, but is BudgieInWA/JOSM2Streets still up-to-date, or are there new rendering goodies corresponding to this?

The JOSM2Streets build embeds StreetNetwork.jar, which in turn embeds the rust lib. If the osm2streets java classes haven't changed their API, then you can build your own StreetNetwork.jar and replace the copy in the JOSM2Streets repo before building. You'd need to do that for these changes, I haven't pushed up the new JAR yet.

BudgieInWA avatar Mar 06 '23 10:03 BudgieInWA

Hi, is this still being considered?

oneil512 avatar Jun 09 '24 06:06 oneil512

I don't think Ben or I have had time to work on this, so not anytime soon. Are you interested in picking it up?

dabreegster avatar Jun 09 '24 08:06 dabreegster