abstreet icon indicating copy to clipboard operation
abstreet copied to clipboard

Design LTN tool - turn restriction editing: testing with `complicated_turn_restictions` required

Open andrewphilipsmith opened this issue 1 year ago • 5 comments

Current behaviour

The LTN turn restriction display and editing features have had limited testing with complicated_turn_restictions. Hence the behaviour may be unspecified and counterintuitive.

Suggesting improvement

Add systematic tests that cover a meaningful range of scenarios involving complicated_turn_restictions.

andrewphilipsmith avatar Sep 06 '23 14:09 andrewphilipsmith

Hi, I would like to take this issue up. As a beginner in Rust I believe this is a good opportunity for me. Kindly let me know.

iakev avatar Oct 04 '23 06:10 iakev

Are you sure you understood what this issue entails? This is less about programming, more about design and testing (and automated testing in Rust is very much NOT a beginner thing)

Zireael07 avatar Oct 04 '23 06:10 Zireael07

Ooh, okay am currently working through the Rust Book and am on automation. With a little guidance I can try my hand. Ithought it was a good first issue. However, I see your point and admittedly I have not really looked into the issue in-depth,so let me leave it then.

iakev avatar Oct 04 '23 07:10 iakev

Hi @iakev, feel free to take on this issue if it's interesting! But I would agree it's maybe a bit tougher to start with. If you wanted something much more focused -- without any UI code to wrangle with particularly -- I might suggest https://github.com/a-b-street/osm2streets/issues/222, if you have any interest in OpenStreetMap data. That issue requires some OSM domain knowledge, but we can also break down some steps if it's useful, so you could focus on the Rust part. It's a very easily unit testable issue, which is why it might be nice to start with.

dabreegster avatar Oct 04 '23 08:10 dabreegster

Hello @dabreegster, I believe that this issue might be a bit complex for me. Let me take your advice and look at the highlighted issue. Thanks for your guidance and suggestions. Thanks @Zireael07 for your concern also.

iakev avatar Oct 04 '23 16:10 iakev