every_door icon indicating copy to clipboard operation
every_door copied to clipboard

Some fields are not translated?

Open matheusgomesms opened this issue 1 year ago • 4 comments

[v4] It seems some fields are not translated, and the translation is not coming from iD presets? PT-BR in EveryDoor is 100% translated on Weblate (by me).

What I can see in English, that should be in PT-BR:

  • Room Number
  • Postcode
  • Elevation (Meters)
  • Levels
  • mobile

Is this an Every Door mistake or iD Preset? I remember seeing those fields translated on iD, but I might be wrong!

matheusgomesms avatar Oct 09 '23 01:10 matheusgomesms

"Room Number" and "Postcode" are indeed not yet translatable. The other three come from presets, I guess.

Zverik avatar Nov 05 '23 21:11 Zverik

In 4.1, I've changed Room Number to be taken from presets, and for Postcode, it's pretty hard to make it translatable, since there is no preset for this field alone.

Zverik avatar Nov 05 '23 21:11 Zverik

Great! I just checked on Transifex, and it seems all of these fields are available on the iD Presets (although I'm not sure how it can be used on the fields). And I also checked PT-BR translations, those fields were already translated.

matheusgomesms avatar Nov 05 '23 22:11 matheusgomesms

Update (which is probably known to you, Ilya, but just to make it easier for future fixes):

What I can see in English, that should be in PT-BR:

Postcode Elevation (Meters) Levels

matheusgomesms avatar May 16 '24 21:05 matheusgomesms

Postcode is still untranslatable, but Levels and Elevation come from presets, there are no such strings in the code.

Zverik avatar May 27 '24 16:05 Zverik

Don't know then what's the cause, because I checked the Presets translations and it's translated there for ages :(

(you can check in EveryDoor, all languages have "Elevation" and "Levels" in English)

matheusgomesms avatar May 27 '24 17:05 matheusgomesms

levels-elevation-translated

Translated for me (the second and the third line). Are you looking at 5.1-beta2?

Zverik avatar May 27 '24 17:05 Zverik

levels-elevation-pt-br

Actually here's pt-BR locale.

Zverik avatar May 27 '24 17:05 Zverik

That's odd! iOS here, 5.1-beta2:

IMG_3239 20240527_171555391_iOS

matheusgomesms avatar May 27 '24 17:05 matheusgomesms

Oh! I see, this is related to references inside the fields files. And I guess this is a bug. I'll see what I can do.

Zverik avatar May 27 '24 17:05 Zverik

Fixed in 5.1, including the postcode!

Zverik avatar May 27 '24 19:05 Zverik

Awesome, thanks a lot, Ilya!

matheusgomesms avatar May 28 '24 17:05 matheusgomesms