every_door icon indicating copy to clipboard operation
every_door copied to clipboard

Rework MultiCombo fields UI to accept a choice of values

Open jolesh opened this issue 2 years ago • 4 comments

Diet tagging has three possible values: yes, no, only

Maybe make a small table with the diet forms on the left and the values selectable, like this: Diets: | vegetarian | no | yes | only | | vegan | no | yes | only | | halal | no | yes | only | ...

Maybe accessible through a menu, just like opening hours opens a dialog.

jolesh avatar Nov 21 '22 09:11 jolesh

I support this. Checking the code, it should require either adding a new ComboType, or changing the current ComboType.multi behaviour.

Robot8A avatar Jul 22 '23 13:07 Robot8A

Hmm. It looks like I did the multiCombo fields wrong, not even supporting "no" values. The iD editor does it right though.

One question: can multiple diet options have the only value?

Zverik avatar Jul 23 '23 07:07 Zverik

Yes, one restaurant could be both for example only gluten-free and only vegetarian.

Robot8A avatar Jul 23 '23 08:07 Robot8A

It would be similar to "Take away only" field.

Maybe we can take the code from there and reuse it?

patepelo avatar Nov 06 '23 12:11 patepelo