every_door icon indicating copy to clipboard operation
every_door copied to clipboard

Instead of adding `was:`, remove all amenity-related tags

Open Zverik opened this issue 2 years ago • 9 comments

Zverik avatar Apr 02 '22 19:04 Zverik

For name, should be old_name instead of was:name because Nominatim index it.

pyrog avatar May 13 '22 09:05 pyrog

The prefix is added only to the main tag (e.g. amenitywas:amenity), the rest are kept.

Zverik avatar May 13 '22 09:05 Zverik

Ok, it could be useful to rename nameold_name ?

Also a vacant shop could be tagged as shop=*was:shop=* + shop=vacant

pyrog avatar May 13 '22 09:05 pyrog

What's the point of shop=vacant? It's not a shop, it doesn't offer any goods or services. Looks like building=no.

Zverik avatar May 13 '22 09:05 Zverik

My city officials use it to know that there is an unoccupied shop at that location. They use it to find all vacant "shops" and discuss with the elected representatives.

For OSM contributors, this is useful to add a new shop (don't need to put the node at the correct place, align it…).

pyrog avatar May 13 '22 09:05 pyrog

Also a vacant shop could be tagged as shop=* → was:shop=* + shop=vacant

proper tagging for existing remains of a shop is disused:shop

Also, disused:shop=* + name=* is better than was:shop=* + old_name

matkoniecz avatar May 18 '22 04:05 matkoniecz

If you want to know what keys should be removed when amenity is replaced (and what keys should be kept), take a look at https://github.com/mnalis/StreetComplete-taginfo-categorize/ (specifically final output files: sc_to_remove.txt or sc_to_keep.txt depending if you want a list of tags to remove, or a list of tags to keep and remove everything else).

That is what StreetComplete uses for same functionality, so it would be useful to reuse the already invested effort.

mnalis avatar Jul 31 '22 15:07 mnalis

Nodes with "was:shop=" are not downloaded and are not displayed in the app, even if the node has become another one "amenity="

Sierzh avatar Jan 05 '23 18:01 Sierzh

Having just found this program I was wondering how unused shops are handled having seen the intro youtube video saying 'just delete it'; didn't like the delete option but video is over a year old.

In other editors I've used multiple disused: entries which I edit as I go. If a shop is permanently closed I used disused:shop=yes. If its name is later removed (likely covered or still stained into paint behind it) then I use disused:name=oldname. I figure it lets mappers know what was there until relevant details are that the shop is renamed, reoccupied, or demolished. I consider a destroyed building is best tagged within a fence, brownfield, or construction site if the details are true at time of observation. All of this helps mappers not just think a detail was missing but rather it was deliberately changed for the current state so they won't copy it in from their observations/streetview/aerial data sources and if they do then there were at least details predating the edit clarifying such error.

In editors, I use disused:shop over shop=disused/vacant/no as it seemed easier to logically not set shop= for a place people cannot shop at and disused: fills a category nicely of 'it was this and is not now' without editors needing to review history before mistakenly recommitting or manually having to readd the details that stayed correct the whole time (address, toilets if not separately mapped which also gives value in setting opening hours to closed or more disused tags as they aren't reachable or functional if building closed and water is off, etc.). Phone number still posted but won't function gets a disused: but if not posted then I just remove it. I know not editing for the renderer is a thing, but having to blacklist shop=no and similar tags in each map generation in each tool that presents maps, POI searches, etc. seems like a silly expectation; best to let their filters choose which shops to display and categorize instead which not-types-of-shops to not display and not categorize that were in the shops category of tags.

mirror176 avatar Sep 21 '23 00:09 mirror176