GoodTwitter
GoodTwitter copied to clipboard
ZusorCode
media playback has pitched-down audio
every embedded twitter media (e.g. not the youtube-originated ones that you can play from the twitter web-interface if a youtube video link has been posted in a tweet) that has an audio stream in it.
steps to reproduce:
- Open any tweet that contains an embedded video (e.g. https://twitter.com/team_salim/status/1141432736462376961)
- press "play"
I've run into this same behaviour on Firefox 68.0 on Linux Mint Tessa and on Firefox 68.0.1 on Ubuntu 18.04.1
I confirm the same behaviour in Arch Linux, firefox 68.0.1. It's definitely this add-on doing it, by simply enabling and disabling it (and refreshing Twitter) the audio either works fine (addon disabled) or is very low pitch and distorted (addon enabled).
same issue here ... pinpointed the issue to the addon after thinking something like Umatrix had a new filter, misbehaving ... not sure how to troubleshoot as this addons (I even tried disabling GoodTwitter and using the same thing as in the code for this addon, in a user-agent switcher, but it shows the new layout that way) .. if someone who is better at coding than I am can find another way to get the old layout back then pinpointing WHAT is happening may be easier.
Tested this on Ubuntu Mate and OpenSuse Tumbleweed Cinnamon (Linux) and so far Google Chrome seems to be a-ok ... it's specific to Firefox and PERHAPS Linux distros?
hmm can multiple people who use this on Windows 10 (or Win7 I guess) confirm that it works ok there? ... I am a Linux (different distros, that all seem effected) and don't use Windows myself
I can confirm that extension causes the reported behavior using Firefox 68 on PopOS! 18.04 (Kernel 5.0.0-21).
Confirmed with firefox 68.0.1-2 amd64 on debian/sid. Distorted audio sounds much lower pitch and also has some crackling, so perhaps clipping. Workaround is to disable GoodTwitter and reload to play an embedded Twitter video.
Confirmed with Nightly 70.0a1 (2019-07-10) (64-bit) on Arch.
It seems to be Twitter loading a different video, based on the modified user agent. Similar problem descriptions I found around the web (e.g. https://github.com/dillbyrne/random-agent-spoofer/issues/563) suggest fixing it with a different user agent string.
I tried a few user agent strings for different Firefox, MSIE, Opera and Safari versions but couldn't find one which loads the old UI and has non-distorted sound. If there was a Linux user agent string which forced the old UI, that might be a solution?
Linux, Ubuntu, Firefox 68.0.1. I've been using youtube-dl to watch videos.
didn't know that the Chrome addon is apparently a different Git repo but yeah Goodtwitter on other browsers seems a-ok regarding this issue ... it's specific to Firefox it seems ... at least with Linux (not sure if that alone makes a difference too)
I keep trying different User Agents with GoodTwitter disabled but all I get in my tests or Twitter forcing a user to the mobile layout with a message "update your browser" or the new layout
Confirmed with Firefox 70.0b3 (64-bit), GoodTwitter 2.0, Ubuntu 19.04 (Linux 5.0.0-25-generic).
I have this problem, too. GoodTwitter 2.0. Firefox 60.8.0esr (64-bit), Debian GNU/Linux 9.9 (stretch).
Would it be possible to merge in the above fix? FF has needlessly complicated the process for installing unsigned add-ons.
Broken for me on Manjaro GNOME 19.1.1, Firefox 69.0.3 Works great in Windows 10 on the same machine.
I wasn't able to test around the time the fix was implemented but it doesn't seem to be working now, at least for me.
thought it was just me (I use a variety of Distros) .. It's at least an issue, on Fedora 31 here with Firefox 70 ... since the time this was closed awhile back, it had been working just fine all that time
Videos play fine for me, still.
GoodTwitter 2.1, Firefox 68.2.0esr (64-bit), Debian GNU/Linux 10 (Buster)
It's back again :( On firefox 70.0 in Arch Linux.
+1
EDIT: I was using the AMO version which is still 2.0.
@ZusorCode Would you mind updating the AMO version, please? It's been a month since the fix.
Unfortunately firefox has been blocking my submissions because of using eval even though it's necessary and haven't replied it any requests to reinstate it. If someone can accomplish the current functionality without eval I could resubmit it.
while i am not sure what use to go into making an xpi file .. I use to know years back in the Firefox 3.x days you could download the addon as a .zip file and then just rename it to .xpi vs .zip and that was it ... also here on github some addons (this does get screwed up if it's sideloaded with say Firefox Sync) like Gorhill's (Ublock Origin and Umatrix) have .XPI here on github under "releases" ... they can even be marked like "stable" (say the current AMO version) and "beta" or something like that IIRC for trials that would let people know this is not the offical AMO release but it may fix standing issues
After spending quite a bit of time today, I managed to make an XPI.
Clone the repository, apply the following patch, make a zip containing everything inside the repository (.git and .github can be excluded), and change the extension to .xpi.
Firefox will most likely refuse to load it because it's unsigned. It works fine in Waterfox. Unless there was a mistake, the ID is the one assigned by AMO and is required for the XPI to load. Without it, Waterfox says the addon is corrupt.
diff --git a/manifest.json b/manifest.json
index a893415..a96af2d 100644
--- a/manifest.json
+++ b/manifest.json
@@ -37,6 +37,11 @@
"icons": {
"128": "128.png"
},
- "content_security_policy": "default-src 'self'"
-
+ "content_security_policy": "default-src 'self'",
+
+ "applications": {
+ "gecko": {
+ "id": "{11cf5a68-57de-4923-88d6-35b0e7d95f57}"
+ }
+ }
}
Confirmed with Firefox 72.0.1 (64-bit), Ubuntu 16.04 (4.15.0-74-generic). Any solutions yet?
Having the same issue on Firefox 72.0.2 (64-bit), Manjaro 18.1.5 (5.4.13-3-MANJARO).
The patch above seems to fix the issue though.
@tatokis Hi, would it be possible for you to post the XPI file somewhere? Some of us are not that familiar with the step-by-step process required to add the patch. Thank you!
