Manuel Drehwald

Results 201 comments of Manuel Drehwald

Jay, turns out the only issue in my test binary was a bug in LLVM, which was already fixed upstream in https://github.com/llvm/llvm-project/pull/143638. Once rustc syncs the llvm submodule again (in...

ok, I think I'm mostly done. Do you have any suggestions? I don't want to add any actual run tests, as these would require a working clang based on the...

> > I don't want to add any actual run tests, as these would require a working clang based on the same commit. > > why is clang necessary for...

> I... don't know if I can review this properly. I can review it from the "does this fit into how I want the llvm backend to look" side, but...

@oli-obk I cleaned up the code a bit more and addressed your feedback. This reduced the number of values which I pass around between functions by a lot. Lmk if...

fwiw, running this directly through rustc or as part of the rust test suite works. Calling cargo fails due to triggering an llvm assertion, because cargo adds `--emit=link`. Everything else...

I removed the cfg gate, happy to not have it rely on Enzyme.

I feel like the large number of helper functions makes it a bit hard to follow. Once we have the other two modules (gpu_wrapper, gpu_device) next to the gpu_offload module,...

https://github.com/rust-lang/rust/pull/140064 You can look at any of the last ~15 failed CI runs, if I try any of the 3 dist-apple runners, Enzyme fails to build due to Enzyme's cmake...

e.g. https://github.com/rust-lang/rust/pull/140064#issuecomment-2840299157 ```bash 2 warnings generated. [100%] Linking CXX shared library libEnzyme-20.dylib clang: warning: argument unused during compilation: '-static-libstdc++' [-Wunused-command-line-argument] ld: library 'LLVM' not found clang: error: linker command failed...