ritchie-cli icon indicating copy to clipboard operation
ritchie-cli copied to clipboard

Change the input flags delimiter to support Windows for double quotes

Open fabianofernandeszup opened this issue 4 years ago • 2 comments

What happened: In windows, input flags do not accept single quotes, just double quotes or without quotes for words without spaces. On Linux and Mac it is possible to use single and double quotes.

My suggestion is to standardize with double quotes to suit all systems equally.

Error Print image

What you expected to happen:

  • Change documentation: https://docs.ritchiecli.io/tutorials/standard-inputs/how-to-use-input-flags

  • Change output on --help flag image

These are the only changes needed.

How to reproduce it (as minimally and precisely as possible):

Run any formula with input flags in the CMD on windows using single quotes and you will see the error.

Environment:

  • Ritchie version (use rit --version): 2.9.0
  • Operating System: Windows

fabianofernandeszup avatar Feb 22 '21 21:02 fabianofernandeszup

@fabianofernandeszup can you ensure that double quotes would run in any kind of command prompt? Is there some prompt in which double quotes would not work?

henriquemoraeszup avatar Feb 26 '21 14:02 henriquemoraeszup

An issue will be opened in cobra related to this subject: https://github.com/spf13/cobra

fabianofernandeszup avatar Jul 07 '21 14:07 fabianofernandeszup