charlescd icon indicating copy to clipboard operation
charlescd copied to clipboard

Fix override deployment

Open thallesfreitaszup opened this issue 3 years ago • 1 comments

Issue Description

When a deployment was being override,all pods was being recreated even that the image tag was not updated

Solution

Instead of concat deployment id on resources, concat the circleId. It was also necessary to remove the deployment id label and now catch the events by the circle id label

thallesfreitaszup avatar Jan 17 '22 14:01 thallesfreitaszup

Codecov Report

Merging #1532 (fe2c1b4) into main (366de8c) will increase coverage by 0.17%. The diff coverage is 86.66%.

:exclamation: Current head fe2c1b4 differs from pull request most recent head 045b805. Consider uploading reports for the commit 045b805 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1532      +/-   ##
============================================
+ Coverage     78.22%   78.39%   +0.17%     
  Complexity     2266     2266              
============================================
  Files          1308     1287      -21     
  Lines         18989    17945    -1044     
  Branches       1651     1658       +7     
============================================
- Hits          14854    14068     -786     
+ Misses         3605     3393     -212     
+ Partials        530      484      -46     
Flag Coverage Δ
butler 88.40% <86.66%> (-0.71%) :arrow_down:
compass ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...2/core/integrations/utils/istio-manifests.utils.ts 100.00% <ø> (ø)
...app/v2/core/logs/console/console-logger.service.ts 85.00% <66.66%> (+2.39%) :arrow_up:
...operator/use-cases/reconcile-deployment.usecase.ts 68.42% <75.00%> (-12.10%) :arrow_down:
...or/logs-aggregator/kubernetes-events-aggregator.ts 91.97% <85.71%> (-2.30%) :arrow_down:
...grations/utils/istio-deployment-manifests.utils.ts 100.00% <100.00%> (ø)
...ations/utils/istio-undeployment-manifests.utils.ts 50.00% <100.00%> (ø)
...er/src/app/v2/core/manifests/helm/helm-manifest.ts 94.04% <100.00%> (ø)
...pp/v2/operator/logs-aggregator/resource-wrapper.ts 100.00% <100.00%> (ø)
.../v2/operator/use-cases/reconcile-routes.usecase.ts 100.00% <100.00%> (ø)
...utler/src/app/v2/operator/utils/reconcile.utils.ts 100.00% <100.00%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 65e263d...045b805. Read the comment docs.

codecov[bot] avatar Jan 17 '22 22:01 codecov[bot]